There's no banner ads in the paid version. You might be still looking at the free one.
Downloading the paid app does not remove the free app from your device. You might still be running the free version and it apparently doesn't know you already have the paid one and would still show ads and ask for upgrade.
The paid version of NOAA Radar Pro has a slightly different icon (on the right).